YARN-11262. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-resourcemanager Part3.#7485
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@cnauroth Could you please review this PR? Thank you very much! |
cnauroth
left a comment
There was a problem hiding this comment.
Hello @slfan1989 . Is this one ready? The last CI run reported some test failures.
@cnauroth Thank you very much for your help in reviewing the code! I will continue to follow up on this PR. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@cnauroth Could you please review this PR again? Thank you very much! I’ve fixed the related unit tests. There are still some Checkstyle warnings, mainly 'Expression can be simplified' issues. After reviewing, I believe these can be addressed in a future PR instead of this one. |
|
🎊 +1 overall
This message was automatically generated. |
cnauroth
left a comment
There was a problem hiding this comment.
+1. Thank you, @slfan1989 !
…esourcemanager Part3. (apache#7485) YARN-11262. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-resourcemanager Part3. Co-authored-by: Chris Nauroth <[email protected]> Co-authored-by: Hualong Zhang <[email protected]> Reviewed-by: Chris Nauroth <[email protected]> Reviewed-by: Hualong Zhang <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Description of PR
JIRA: YARN-11262. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-server-resourcemanager Part3.
How was this patch tested?
Junit Test & mvn clean test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?